New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading nested NoopStreams with sharebuf=false produces garbage data #187

Merged

nhz2 merged 1 commit into master from nz/fix-noop-regression

Mar 22, 2024

Member

nhz2 commented Mar 22, 2024 •

edited

Loading

Fixes #186 and adds some tests.

This seems to be a typo from #168


          fix bug

bc5532d

nhz2 marked this pull request as ready for review

March 22, 2024 00:35

nhz2 requested a review from vtjnash

March 22, 2024 00:36

vtjnash approved these changes

View reviewed changes

Member Author

nhz2 commented Mar 22, 2024

Thanks for the fast review. I'll release a patch tomorrow.

nhz2 merged commit 9cf5343 into master

22 checks passed

nhz2 deleted the nz/fix-noop-regression branch

March 22, 2024 03:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet